UPSTREAM PR #19531: Kimi Linear (correct conv state update + block implementation)#1165
Open
UPSTREAM PR #19531: Kimi Linear (correct conv state update + block implementation)#1165
Conversation
…t for faster inference. sync'd to b7682
loci-dev
force-pushed
the
main
branch
12 times, most recently
from
f9aec49 to
e6c519b
Compare
loci-dev
force-pushed
the
main
branch
9 times, most recently
from
135dbe7 to
89a1190
Compare
loci-dev
force-pushed
the
main
branch
9 times, most recently
from
6ef937b to
3655621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: ggml-org/llama.cpp#19531
Make sure to read the contributing guidelines before submitting a PR
The current implementation has incorrect conv state update such that it has state corruption when running parallel in llama-server. This is fixed in this PR.
This PR also includes the block implementation that speeds up 20% pp and VRAM saving.